Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work for openssl-1.1 support #559

Closed
wants to merge 3 commits into from
Closed

Conversation

xeroc
Copy link
Member

@xeroc xeroc commented Jan 5, 2018

This updates the fc version to another branch that started fixing openssl-1.1
it also disabled deterministic_openssl_rand because it's not used anywhere

This repo builds just fine.

For reference:
bitshares/bitshares-fc#7

@xeroc
Copy link
Member Author

xeroc commented Feb 14, 2018

Unfortunately, the required patch is still not merged into websocketcpp. These are the steps necessary to compile bitshares-core / bitshares-fc with openssl-1.1:

cd libraries/fc/vendor/websocketpp
git checkout 0.7.0
git remote add locutus https://github.com/LocutusOfBorg/websocketpp/
git fetch locutus
git cherry-pick 1dd07113f2a7489444a8990a95be42e035f8e9df

Then recompile.

@xeroc
Copy link
Member Author

xeroc commented Feb 14, 2018

I have pushed an update to the fc repo.
Since the websocketpp repo needed a manual patch, I forked it over to bitshares project on github.
To apply the submodule change, you need to

git submodule sync --recursive
git submodule update --init --recursive

@xeroc xeroc force-pushed the openssl-1.1-support branch from bcf5a08 to b354bac Compare March 22, 2018 14:56
@xeroc xeroc force-pushed the openssl-1.1-support branch from b354bac to eb28af0 Compare March 22, 2018 15:00
Copy link
Contributor

@jmjatlanta jmjatlanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been using this PR along with the boost_1.66 PR with great success. Please fix the merge conflict, (perhaps just a rebase?) and I believe we're good-to-go!

@xeroc
Copy link
Member Author

xeroc commented Apr 12, 2018

@jmjatlanta This pull request actually only picks a certain 'fc' commit (and comments some old CMake project out) ... The real thing happens in bitshares/bitshares-fc#7

@pmconrad pmconrad mentioned this pull request May 13, 2018
1 task
@pmconrad
Copy link
Contributor

Replaced by #921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants