Issue491: Minor delta_debt amount check issue in call_order_update_evaluator #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
reviewed
Jan 30, 2018
libraries/chain/market_evaluator.cpp
Outdated
| @@ -189,6 +175,7 @@ void_result call_order_update_evaluator::do_apply(const call_order_update_operat | |||
| { | |||
| d.modify(_paying_account->statistics(d), [&](account_statistics_object& stats) { | |||
| stats.total_core_in_orders += o.delta_collateral.amount; | |||
| assert(dynamic_asset.current_supply <= 0); | |||
There was a problem hiding this comment.
This is apparently wrong.
By the way don't use assert(), see #511
|
i re added the |
|
Perhaps better rebase/squash the commits. |
|
it can be done at merge time(the squash) into 1 commit if you approve the changes. |
abitmore
approved these changes
Feb 2, 2018
abitmore
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#491