BSIP35 mitigate rounding issue when matching orders #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmconrad all done. Please review again. |
|
I'm missing something-for-nothing variant C-1 in the test output. Is that also just a theoretical possibility, like D-1/D-2, or was it overlooked? |
|
@pmconrad added more tests to cover C-1 and cull-settle logic. Update: forced-pushed due to wrong git comment. |
abitmore
force-pushed
the
bsip35-order-rounding
branch
from
6695232 to
fdc1612
Compare
pmconrad
reviewed
Apr 26, 2018
libraries/chain/db_market.cpp
Outdated
| // Be here, it's possible that taker is paying something for nothing due to partially filled in last loop. | ||
| // In this case, we see it as filled and cancel it later | ||
| // TODO remove hardfork check when we're sure it's always true (but keep the zero amount check) | ||
| if( order_receives.amount == 0 && maint_time > HARDFORK_CORE_184_TIME ) |
There was a problem hiding this comment.
Perhaps add an ilog() here so we can later check if the case is relevant.
libraries/chain/db_market.cpp
Outdated
| if( order_receives.amount == 0 && maint_time > HARDFORK_CORE_184_TIME ) | ||
| return 1; | ||
|
|
||
| if( before_core_hardfork_342 ) // TODO remove this "if" when we're sure it's always false (keep the code in else) |
There was a problem hiding this comment.
Perhaps add an ilog() here so we can later check if the case is relevant.
libraries/chain/db_market.cpp
Outdated
| { | ||
| order_receives = usd_to_buy * match_price; // round down here, in favor of call order | ||
| // TODO remove hardfork check when we're sure it's always true (but keep the zero amount check) | ||
| if( order_receives.amount == 0 && maint_time > HARDFORK_CORE_184_TIME ) |
There was a problem hiding this comment.
Perhaps add an ilog() here so we can later check if the case is relevant.
|
@pmconrad thanks. Logging added. |
pmconrad
approved these changes
Apr 26, 2018
This was referenced Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of changes on the market engine, cherry-picked from #641, including changes related to #132, #184, #342 and BSIP35: Mitigate Rounding Issue On Order Matching.
The code is ready for review. In the meanwhile I'll finish the missing test cases, including: