Bsip36: clear expired feeds on maintenance interval #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmjatlanta
approved these changes
May 7, 2018
jmjatlanta
reviewed
May 7, 2018
libraries/chain/db_maint.cpp
Outdated
| std::advance( itr, 1 ); | ||
| if( feed_time < calculated ) | ||
| o.feeds.erase( itr.base() ); // delete expired feed | ||
| } |
There was a problem hiding this comment.
Up to you, but you could replace this with something like:
o.feeds.erase(
std::remove_if(o.feeds.begin(), o.feeds.end(),
[calculated] (auto f) { return f.second.first < calculated; }),
o.feeds.end());
(Untested, just typing out loud)
There was a problem hiding this comment.
Oops, sorry. remove_if doesn't work for map (until perhaps C++20). Please ignore.
pmconrad
suggested changes
May 7, 2018
libraries/chain/db_maint.cpp
Outdated
|
|
||
| for( const auto& d : get_index_type<asset_bitasset_data_index>().indices() ) | ||
| { | ||
| modify( d, [this,head_time,head_epoch_seconds,after_hf_core_518]( asset_bitasset_data_object &o ) |
There was a problem hiding this comment.
Nothing in the capture list changes within the for-loop, it would be more efficient to pull the lambda creation out of the loop.
| @@ -176,6 +176,9 @@ namespace graphene { namespace chain { | |||
| static const uint8_t space_id = implementation_ids; | |||
| static const uint8_t type_id = impl_asset_bitasset_data_type; | |||
|
|
|||
| /// The asset this object belong to | |||
| asset_id_type asset_id; | |||
There was a problem hiding this comment.
Must bump GRAPHENE_CURRENT_DB_VERSION when modifying DB object structures.
pmconrad
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR for issue: #518, refactored from PR #832.
BSIP: https://github.com/bitshares/bsips/blob/master/bsip-0036.md