Skip to content

Commit

Permalink
Fix warnings
Browse files Browse the repository at this point in the history
The `appender` class is intended to be inherited and used polymorphically, but does not have a virtual destructor, which causes warnings. This adds a virtual destructor to fix these warnings.
  • Loading branch information
nathanielhourt authored Aug 29, 2019
1 parent 1d2d9bf commit cce644f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions include/fc/log/appender.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ namespace fc {
return register_appender( type, appender_factory::ptr( new detail::appender_factory_impl<T>() ) );
}

virtual ~appender() = default;
static appender::ptr create( const std::string& name, const std::string& type, const variant& args );
static appender::ptr get( const std::string& name );
static bool register_appender( const std::string& type, const appender_factory::ptr& f );
Expand Down

0 comments on commit cce644f

Please sign in to comment.