-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hash160 algorithm #143
Conversation
AFAICS the only place where |
This PR will help with the HTLC improvements BSIP that will hopefully be accepted. https://github.com/bitshares/bsips/blob/master/bsip-0064.md |
There are new changes on the |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems your encoder implementation lacks of a reset()
function, which means callers need to multiple encoder instances for encoding multiple items.
Was in header, but forgot to implement. Nice catch. |
I don't know why |
Thanks. |
This algorithm is used by Bitcoin's BSIP199 for Hashed Time Lock Contracts. This is part of BitShares BSIP64
I attempted to remove the impl, as I am not using it. Unfortunately things will not compile without it, and I am not familiar with the templates that answer "why" this is the case. I can leave it as is, move the SHA256 stuff into the impl, or spend more time digging into the "why" and see what I can do.
Suggestions appreciated.