Remove custom FindBoost.cmake #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis is complaining. It works on my 16.04 and 18.04 Ubuntu boxes. I am attempting to find out what is going on. |
|
Getting the same error locally. Apparently |
That stinks. From what I read, they fixed an issue with that back in the 2.x versions of cmake. I guess it crept up again. What version of cmake are you using? |
|
With my last commit here it works again. Apparently removing BoostConfig was too much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A custom FindBoost.cmake was added to resolve a v2.x version cmake bug. We now only support cmake 3.2 and above, so the extra steps included are no longer necessary.