Replace improper static_variant operator overloads with comparators #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static_variantprovided operator overloads for == and < which compared only the types and not the values. This was used to make it easier to placestatic_varianttypes intoflat_sets, but it constitutes a dangerous abuse of C++ operator overloading as code could accidentally be written using these operators and expecting them to be correctly implemented. Such code would be invisibly wrong. Removing these overloads eliminates this risk.This commit removes the overloads and replaces them with comparator structs, and also provides a convenient type alias for a
flat_setofstatic_varianttypes.Requisite changes in BitShares are visible here and will be PReq'd after this is merged.