Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip editline when building in MSVC #34

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Skip editline when building in MSVC #34

merged 1 commit into from
Mar 27, 2018

Conversation

abitmore
Copy link
Member

No description provided.

@abitmore abitmore mentioned this pull request Mar 27, 2018
Open
jmjatlanta
jmjatlanta approved these changes Mar 27, 2018
View reviewed changes
Copy link

@jmjatlanta jmjatlanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Visual Studio 2017 (MSVC14). This does what is intended. Editline is no longer compiled as part of FC when using MSVC.

@abitmore abitmore merged commit 4dbf6ee into master Mar 27, 2018
@abitmore
Copy link
Member Author

Hmm, I merged too fast. Perhaps better to add a TODO so we can re-visit the issue later. Perhaps better to remove the commented out code.

@abitmore abitmore deleted the msvc-editline branch March 28, 2018 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmjatlanta jmjatlanta jmjatlanta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abitmore @jmjatlanta