Added Citadel gateway #1695

snakebitekit · 2018-07-13T12:31:43Z

Hi, it's citadel gateway which supports citadel.monero tokens and monero(xmr) coins.
Both main and beta deposit&withdraw interfaces are tested and working, you can check it on our prod server: https://citadel.li/wallet/#/deposit-withdraw

There's one more question by the way: can i add a citadel's help block in this pr or should i do it in another?

sschiessl-bcp · 2018-07-20T14:21:51Z

We will get back to you on this pull request.

Your link above seems to not work anymore. I assume you only added into the modal? It also is shown as disabled right now.

snakebitekit · 2018-07-20T16:43:24Z

@sschiessl-bcp hm, can u try to log in and recheck it?
because on my side everything is ok:

startailcoon

Assets aliases should be handled with code from the API Settings, rather than within the code directly.

startailcoon · 2018-07-20T21:40:48Z

app/components/Modal/WithdrawModalNew.jsx

- ? selectedGateway.toLowerCase() + "." + assetName
- : assetName;
+ if (
+ assetName.toLowerCase() === "monero" &&


I don't like this change as the new modals aim to be generalized for making it easier to add new gateways. I would rather have this done on a per gateway in the settings file.

Something like
assetWithdrawlAlias: { monero: xmr }

startailcoon · 2018-07-20T21:42:36Z

app/lib/common/gatewayMethods.js

@@ -276,6 +276,12 @@ export function requestDepositAddress({
 url = openledgerAPIs.BASE,
 stateCallback
 }) {
+ if (


This should also be handled in a gateway specific setting

snakebitekit · 2018-07-22T08:28:47Z

@startailcoon ty for your correction
i've made a commit to handle this: 7213e01

snakebitekit · 2018-07-31T21:54:06Z

@startailcoon @sschiessl-bcp does it look fine or do i need to fix something else?

startailcoon · 2018-08-01T07:31:11Z

@snakebitekit I can do a review of this in the coming days

snakebitekit · 2018-08-01T18:02:53Z

@startailcoon great, thanks!

snakebitekit · 2018-08-07T09:05:50Z

hi, @startailcoon
how is it going?

startailcoon · 2018-08-07T09:27:41Z

I've had issues with my developer computer setup, which made me delayed in the process. You're not forgotten and I will look at this as soon as possible.

snakebitekit · 2018-08-07T09:48:53Z

@startailcoon ok, thanks for reply.
we're really looking forward to it.
if you need some tokens or transaction history to prove it – i'll send it back to you, just ask)

startailcoon · 2018-08-07T19:01:17Z

Some tokens would be good to be able to make some test transactions.
You can send them to account startail-test

startailcoon · 2018-08-07T19:26:05Z

I've detected 1 issue and a few changes that I will submit when I've finished testing. It does look good and works well.

I've looked trough the functions of the legacy Deposit/Withdraw function, which I'll test as soon as I have some tokens.

One issue is the Modal that will require some layout fixes to support some issues with the text being to long as well as the address being very very long.

An example is the deposit address I receive: 4GvPuQofExxWapNcJvj6yU1oYhLXm9rPvRgH9TubBUej1Z44c7QatQABMsaAx1hWYHMiMHHtaYYGPjVtt1iHLSsL9zXJhdgeP7876CECi1

We will need to wrap this elegantly, without making it break something else.

sschiessl-bcp · 2018-08-07T19:58:35Z

I've looked trough the functions of the legacy Deposit/Withdraw function, which I'll test as soon as I have some tokens.

When will it be legacy? Or receive a make-over to stick to the logic from the modal?

startailcoon · 2018-08-07T20:18:40Z

When will it be legacy? Or receive a make-over to stick to the logic from the modal?

I'm not sure, but we've talked about doing something about it. They are more Gateway specific, and could probably stay in one form or another. They provide some more space for gateway specific features and functions, like updates, news, contact details etc. I see these sections more of a space where the gateways can and should take care of their own code, push PRs when they want an update etc.

Further discussion about Withdraw/Deposit section is on issue #1479

snakebitekit · 2018-08-08T10:10:47Z

@startailcoon we've sent some citadel.monero tokens to startail-test account.

- Handle longer addresses on Deposit + Confirm - Fix 'assetWithdrawlAlias' when gateway is missing option - Various minor style fixes

startailcoon · 2018-08-09T17:11:18Z

I've supplied a commit with some changes to fix some issues with this PR.
Overall this looks good and it works well when I've tested it.

I can't confirm the Deposit feature. I tried to withdraw 0.1 CITADEL.MONERO to the assigned deposit address, but it didn't show up.

startailcoon

Supplied commit fixes the assetWithdrawlAlias issue with gateways that had no alias params.

- Fixes long deposit address on DepositWithdraw component

startailcoon · 2018-08-09T17:37:47Z

Additionally you should commit a document named citadel.md to the app\help\en\gateways folder to view for users that click the question mark on deposit and withdraw modal.

Link this document to the toc.md document. This will then be viewed in the help section under gateways.

snakebitekit · 2018-08-10T13:42:00Z

@startailcoon okay, i'll add a help block and commit it.
can we chat directly in messenger to debug more fluently? telegram\discord etc..
i've found you on discord by the way, is it comfortable way to chat for you?

…into citadel-develop-gateway && fixing conflicts

startailcoon

Also need to add word-break to Transactions memo as the address is so long.

<td className="memo" style={{wordBreak: "break-all"}}>{text}</td>

On

bitshares-ui/app/components/Blockchain/Transaction.jsx

Line 172 in 03843a8

startailcoon · 2018-08-17T20:14:28Z

app/components/DepositWithdraw/citadel/CitadelBridgeDepositRequest.jsx

+ this.props.asset.get("id")
+ )
+ ) {
+ if (


This will fail when amount_to_withdraw is null or undefined.

Please add the following

!!this.props.amount_to_withdraw &&

ty, is it ok now 99974bd ?

snakebitekit · 2018-09-02T15:17:30Z

sup?

app/api/apiConfig.js

snakebitekit added 2 commits July 13, 2018 15:30

citadel-gateway

e9fa3aa

locales update

a29176a

snakebitekit mentioned this pull request Jul 18, 2018

[2] adding new gateway to ui #1593

Closed

startailcoon reviewed Jul 20, 2018

View reviewed changes

assetWithdrawlAlias to api settings

7213e01

snakebitekit added 3 commits July 26, 2018 16:57

conflict fix

8a65c94

fix

5fd6e0e

conflict fix

c305f2b

startailcoon self-requested a review August 1, 2018 08:58

snakebitekit and others added 3 commits August 1, 2018 15:33

Merge branch 'develop' into citadel-develop-gateway

cc365d5

conflict fix

3a12c67

Merge branch 'develop' into citadel-develop-gateway

1a9b20b

startailcoon mentioned this pull request Aug 7, 2018

[1][wmbutler][3][kapeer] UX for Send/Deposit/Withdraw beta -> legacy #1479

Closed

deposit address styles fix

ed05ef9

Requested changes for Citadel Gateway Integration

67ca53b

- Handle longer addresses on Deposit + Confirm - Fix 'assetWithdrawlAlias' when gateway is missing option - Various minor style fixes

startailcoon approved these changes Aug 9, 2018

View reviewed changes

Requested changes for Citadel Gateway Integration

250564a

- Fixes long deposit address on DepositWithdraw component

snakebitekit and others added 5 commits August 14, 2018 14:08

added citadel help block

b39d377

updt

6f69d94

confilcts fix

3d4a295

Merge branch 'develop' of https://github.com/snakebitekit/bitshares-ui …

50b54f9

…into citadel-develop-gateway && fixing conflicts

take changes from develop

3e3d20f

startailcoon suggested changes Aug 17, 2018

View reviewed changes

review upd

99974bd

startailcoon approved these changes Aug 18, 2018

View reviewed changes

Merge branch 'develop' into citadel-develop-gateway

873d412

sschiessl-bcp requested changes Sep 5, 2018

View reviewed changes

app/api/apiConfig.js Outdated Show resolved Hide resolved

app/api/apiConfig.js Outdated Show resolved Hide resolved

api links fix

2b81d14

sschiessl-bcp approved these changes Sep 6, 2018

View reviewed changes

sschiessl-bcp merged commit dd114f8 into bitshares:develop Sep 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Citadel gateway #1695

Added Citadel gateway #1695

snakebitekit commented Jul 13, 2018 •

edited

Loading

sschiessl-bcp commented Jul 20, 2018

snakebitekit commented Jul 20, 2018

startailcoon left a comment

startailcoon Jul 20, 2018

startailcoon Jul 20, 2018

snakebitekit commented Jul 22, 2018

snakebitekit commented Jul 31, 2018 •

edited

Loading

startailcoon commented Aug 1, 2018

snakebitekit commented Aug 1, 2018

snakebitekit commented Aug 7, 2018 •

edited

Loading

startailcoon commented Aug 7, 2018

snakebitekit commented Aug 7, 2018

startailcoon commented Aug 7, 2018

startailcoon commented Aug 7, 2018

sschiessl-bcp commented Aug 7, 2018

startailcoon commented Aug 7, 2018 •

edited

Loading

snakebitekit commented Aug 8, 2018

startailcoon commented Aug 9, 2018

startailcoon left a comment

startailcoon commented Aug 9, 2018 •

edited

Loading

snakebitekit commented Aug 10, 2018

startailcoon left a comment

startailcoon Aug 17, 2018

snakebitekit Aug 18, 2018

snakebitekit commented Sep 2, 2018

Added Citadel gateway #1695

Added Citadel gateway #1695

Conversation

snakebitekit commented Jul 13, 2018 • edited Loading

sschiessl-bcp commented Jul 20, 2018

snakebitekit commented Jul 20, 2018

startailcoon left a comment

Choose a reason for hiding this comment

startailcoon Jul 20, 2018

Choose a reason for hiding this comment

startailcoon Jul 20, 2018

Choose a reason for hiding this comment

snakebitekit commented Jul 22, 2018

snakebitekit commented Jul 31, 2018 • edited Loading

startailcoon commented Aug 1, 2018

snakebitekit commented Aug 1, 2018

snakebitekit commented Aug 7, 2018 • edited Loading

startailcoon commented Aug 7, 2018

snakebitekit commented Aug 7, 2018

startailcoon commented Aug 7, 2018

startailcoon commented Aug 7, 2018

sschiessl-bcp commented Aug 7, 2018

startailcoon commented Aug 7, 2018 • edited Loading

snakebitekit commented Aug 8, 2018

startailcoon commented Aug 9, 2018

startailcoon left a comment

Choose a reason for hiding this comment

startailcoon commented Aug 9, 2018 • edited Loading

snakebitekit commented Aug 10, 2018

startailcoon left a comment

Choose a reason for hiding this comment

startailcoon Aug 17, 2018

Choose a reason for hiding this comment

snakebitekit Aug 18, 2018

Choose a reason for hiding this comment

snakebitekit commented Sep 2, 2018

snakebitekit commented Jul 13, 2018 •

edited

Loading

snakebitekit commented Jul 31, 2018 •

edited

Loading

snakebitekit commented Aug 7, 2018 •

edited

Loading

startailcoon commented Aug 7, 2018 •

edited

Loading

startailcoon commented Aug 9, 2018 •

edited

Loading