Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rand 0.7 & criterion 0.4 and disable OS random number generator #19

Merged
merged 3 commits into from
Sep 14, 2019

Conversation

repi
Copy link
Contributor

@repi repi commented Sep 14, 2019

Disabled default features on rand to avoid pulling in things that are not needed, such as the OS random number generator in getrandom.

Want to be able to build for wasm32-unknown-unknown without having this pulled in because if called it will just panic (as there is no OS).

Unfortunately I think in practice due to criterion using rand with all features it will enable all features here also even though criterion is just a dev-dependency. But that is a separate cargo issue for now.

And good to use latest rand 0.7 anyway with minimal features.

And I do agree with #6 that ideally both rand and approx should be disabled by default.

@bitshifter bitshifter merged commit 516e11a into bitshifter:master Sep 14, 2019
@bitshifter
Copy link
Owner

Thanks again. I'd like to make the rand dependency optional at some point. I just need to remove the dependency on it in tests and bench.

@repi repi deleted the rand branch September 14, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants