Update rand 0.7 & criterion 0.4 and disable OS random number generator #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled default features on
rand
to avoid pulling in things that are not needed, such as the OS random number generator ingetrandom
.Want to be able to build for
wasm32-unknown-unknown
without having this pulled in because if called it will just panic (as there is no OS).Unfortunately I think in practice due to
criterion
usingrand
with all features it will enable all features here also even thoughcriterion
is just a dev-dependency. But that is a separate cargo issue for now.And good to use latest
rand
0.7 anyway with minimal features.And I do agree with #6 that ideally both
rand
andapprox
should be disabled by default.