Fix Mat4::look_at_lh/rh #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaikKlein
reviewed
Sep 17, 2019
|
Thanks. I don't use these in my little hobby projects so they haven't really had any love. I think I copied them from nalgebra or something but obviously messed it up. They're still not public though, are you using them somehow or did you just notice they were incorrect? |
|
Yeah easy to get something wrong with it. The Thanks for quick merge! |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Mat4::look_at_lhimplementation was a broken with lacking normalization, doing the cross products in the wrong order and some flips.I'm not 100% sure if this is correct but with these fixes it matches the behavior of
glm::look_at_rhand also the implementation in DirectXMathXMMatrixLookToLH, though I've only in practice tested the right-handed version as that is what we use.