This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Fix finding latest feedback message having an ID #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation stopped at the first message having an ID instead of, as the method name suggests, getting the last item. This change fixes the detection of knowing if there are new messages incoming from the server the user didn’t see yet and hence makes the use of the `showAlertOnIncomingMessages` actually possible.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation stopped at the first message having an ID instead of, as the method name suggests, getting the last item.
This change fixes the detection of knowing if there are new messages incoming from the server the user didn’t see yet and hence makes the use of the
showAlertOnIncomingMessagesactually possible.This problem should also apply to the iOS implementation.