-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add embedded std #467
Add embedded std #467
Conversation
c2a1182
to
9b073c6
Compare
@@ -0,0 +1,30 @@ | |||
# SPDX-FileCopyrightText: 2022 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a just written file, not a two year old file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, should have looke more carefully at the copyrights :)
What types are the ones that cause you trouble? Because I see that we are using a different feature flag, |
Oh nice! I'll take a look at those features and see if they cover my use cases :) |
It turns out the I did make a pull request for it on their repository For now I propose we do continue adding this package. If we don't find any value for it besides this trait I'd like to remove it if |
Having our own std library with newtypes allows us to implement traits of `ufmt`.
9b073c6
to
dff18dc
Compare
Lara pointed out we can just use the |
Rust's orphan rules prevent us from deriving traits like
uDisplay
,uDebug
anduWrite
from theufmt
package, effectively preventing us from formatting strings with existing types.Therefore I propose to create an
std
like package that contains newtype wrappers for commonly used datatypes.A first example is
string.rs
that usesString
fromheapless
.