Filter NULL bytes in expectLine
#682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Picocom sometimes produces NULL bytes. Attempts to debug this behavior have been futile, so this patch simply filters them out. This does remove the ability to send over binary data, but I don't think we want to do that over UART anyway..
martijnbastiaan
force-pushed
the
filter-null-bytes
branch
from
2921a24 to
cef3372
Compare
lmbollen
approved these changes
Nov 22, 2024
leonschoorl
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picocom sometimes produces NULL bytes. Attempts to debug this behavior have been futile, so this patch simply filters them out. This does remove the ability to send over binary data, but I don't think we want to do that over UART anyway..
Note: this removes a call to
trim, in favor oftrimEnd. We don't want to strip start of line whitespace..