WIP: Encrypted torrents for Bittorrent v2 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove section on keys in torrents - specify separate torrent key files instead - better single file / multi file handling
- don't include infohashes in key file
- mandate single-file layout for public data - mandatory shadow dictionary
ssiloti
reviewed
Aug 16, 2017
beps/bep_0054.rst
Outdated
|
|
||
| If a client has access to at least a shadow key it may want to check consistency, such as the length and number of pieces, between the encrypted representation and the plaintext metadata in the shadow dictionary. | ||
| It may also want to display the metadata of the plaintext to the user instead of the encrypted representation. | ||
| Since the shadow dictionary also contains merkle roots for each file correct decryption can also be verified at the file granularity level. Transfer of plaintext merkle layers is not supported, but clients can still use deduplication if they other files with identical plaintext. |
There was a problem hiding this comment.
Typo in last sentence.
if they have other files with identical plaintext.
beps/bep_0054.rst
Outdated
| 8. verify ``SIV`` | ||
| 9. derive ``payload_nonce`` from ``infohash_plain`` and ``salt`` | ||
| 10. if ``payload_key`` is available decrypt ``plaintext_padded`` | ||
| 11. split `plaintext_padded`` according to file layout information in the plaintext info dictionary |
There was a problem hiding this comment.
missing opening backtick for plaintext_padded
beps/bep_0054.rst
Outdated
| 17. add the following key value pair to the info dictionary of the encrypted torrent: ``"enc mac": mac`` | ||
|
|
||
| This construction | ||
| * obscures the exact size of the plaintext by rounding to the nearest piece size |
There was a problem hiding this comment.
There needs to be a blank line inserted above this one to get the bulleted list formatting.
|
I have realized that info-dictionary level encryption metadata is in conflict with or would significantly complicate mutable torrents, torrent feeds etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have revised my draft to be based around BEP52
drawback: needs 2 passes over the content
It's still a WIP since I need to update my prototype to generate test data