Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite existing vm.args file on release.init #585

Closed
mobileoverlord opened this issue Nov 5, 2018 · 1 comment
Closed

Do not overwrite existing vm.args file on release.init #585

mobileoverlord opened this issue Nov 5, 2018 · 1 comment

Comments

@mobileoverlord
Copy link
Contributor

mobileoverlord commented Nov 5, 2018

Steps to reproduce

mix nerves.new test_app
...
Fetch and install dependencies? [Yn] Y

rel/vm.args file that nerves needs is overwritten by the one from distillery

Description of issue

The Nerves new project generator includes a custom release config.exs and a customized vm.args file. When mix release.init is called, the vm.args file is overwritten by the version Nerves needs. This is causing all new projects to be generated to fail to boot Nerves devices. Distillery should not overwrite existing files.

mobileoverlord added a commit to nerves-project/nerves that referenced this issue Nov 5, 2018
mobileoverlord added a commit to nerves-project/nerves that referenced this issue Nov 5, 2018
@bitwalker
Copy link
Owner

Sorry about that, this came in via PR, usually I'm careful about this kind of thing :( - a new release has been pushed to Hex with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants