Update "Deploying with Docker" docs for Elixir 1.12 #737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
I'm not necessarily suggesting this PR be merged, I'm curious to hear what others think about the solution. My app's docker image was heavily influenced by the "Deploying with Docker" distillery docs, and I ran into an issue when upgrading to Elixir 1.12. Namely using the
elixir:1.12.1-alpine
base image results in errors being thrown becauselibstdc++.so.6
is missing. Following along at erlef/docker-elixir#20 I see this is because the new JIT feature in OTP 24 expects to dynamically linklibc
, but alpine usesmusl
instead. The solution there is to addlibstdc++
back into the final container.Checklist
Licensing/Copyright
By submitting this PR, you agree to the following statement, please read before submission!
I certify that I own, and have sufficient rights to contribute, all source code and
related material intended to be compiled or integrated with the source code for Distillery
(the "Contribution"). My Contribution is licensed under the MIT License.
NOTE: If you submit a PR and remove the statement above, your PR will be rejected. For your PR to be
considered, it must contain your agreement to license under the MIT license.