Do not update tracker clock with registry entry clocks #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up of bitwalker#85 I forgot to change the handle_topology_change method which is as far as I can tell also the root cause for bitwalker#106
|
I managed to reproduce #106 and this is happening because the clock gets forked on every anti-entropy sync. I removed the fork and added some more debug output when clock-forks are happening which should only be when a new node joins a cluster. |
|
This is great! Do you think the situation you describe could be made reproducible in a testcase? |
- Added test for inspecting the node state after sync to make sure that clocks are still correct. - Fix sync test which was not testing concurrent clocks
|
Added a test case |
|
This looks good so far, as I've been able to duplicate #106 myself I am going to pull this down and give it a spin. |
|
Tests are failing ... Any news on this ? This seems like a pretty critical and important fix ! |
|
Tests have been failing on the master branch before. Did this change cause any new failures? |
arjan
approved these changes
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #85
I forgot to change the handle_topology_change method which is
as far as I can tell also the root cause for
#106