Update CI, dependencies and fix deprecations #772
+42
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathany-copia
commented
Dec 23, 2024
| @@ -1202,7 +1202,7 @@ defmodule Timex do | |||
| def day_to_num(unquote(atom)), do: unquote(day_num) | |||
| end | |||
|
|
|||
| Module.eval_quoted(__MODULE__, day_quoted, [], __ENV__) | |||
| Code.eval_quoted(day_quoted, [], __ENV__) | |||
There was a problem hiding this comment.
Code.eval_quoted exists in very early versions of Elixir, so this shouldn't impact the minimum Elixir version required for this library.
Test with current versions of dependencies Module.eval_quoted/4 is deprecated. Use Code.eval_quoted/3 instead
nathany-copia
commented
Jan 6, 2025
| @@ -7,13 +7,20 @@ on: | |||
| jobs: | |||
| test: | |||
| runs-on: ubuntu-latest | |||
| continue-on-error: ${{ matrix.experimental }} | |||
There was a problem hiding this comment.
The idea with this experimental flag is it allows testing with release candidates of future elixir versions without breaking the build or preventing a merge, but it allows the results of to be seen in CI.
|
Would be nice if this could get merged and released! |
|
@bitwalker Any chance you could review this? Is there anyone else able to approve the workflow and merge PRs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Updates Timex CI and dependencies to resolve compiler warnings and ensure that the code compiles and tests pass in the most recent 2 versions of Elixir (if additional older versions are desired, those can be added)
Fixes #771
Checklist
https://github.com/elixir-gettext/gettext/blob/main/CHANGELOG.md#v0260