Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-3513] Show error SSO policy #2707

Merged
merged 2 commits into from
Aug 18, 2023
Merged

[PM-3513] Show error SSO policy #2707

merged 2 commits into from
Aug 18, 2023

Conversation

andrebispo5
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Show the api error when a user tries to Login with device but there is an SSO only policy enforced.

Code changes

Catch Api exception and show internal error message.

Screenshots

image

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

jlf0dev
jlf0dev previously approved these changes Aug 18, 2023
@bitwarden-bot
Copy link

bitwarden-bot commented Aug 18, 2023

Logo
Checkmarx One – Scan Summary & Details8855cd62-193b-46d5-af82-06f22c58059a

No New Or Fixed Issues Found

@andrebispo5 andrebispo5 merged commit e274c04 into master Aug 18, 2023
@andrebispo5 andrebispo5 deleted the auth/pm-3513-ssopolicy branch August 18, 2023 22:05
andrebispo5 added a commit that referenced this pull request Aug 18, 2023
* [PM-3513] Show API error when SSO policy is enforced.

(cherry picked from commit e274c04)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants