Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-3545] Fix biometric unlock for autofill #2710

Merged
merged 2 commits into from
Aug 21, 2023
Merged

[PM-3545] Fix biometric unlock for autofill #2710

merged 2 commits into from
Aug 21, 2023

Conversation

andrebispo5
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Extension code was not updated for the user to be able to unlock with biometrics using new UserKey model.

Code changes

Set user key after biometric is valid.

Screenshots

Screen.Recording.2023-08-21.at.09.43.26.mov

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@andrebispo5 andrebispo5 requested review from fedemkr and jlf0dev August 21, 2023 08:44
@bitwarden-bot
Copy link

bitwarden-bot commented Aug 21, 2023 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – da6a89ae-821d-41f4-be0c-fe7183114eea

No New Or Fixed Issues Found

@andrebispo5 andrebispo5 requested a review from jlf0dev August 21, 2023 19:06
@andrebispo5 andrebispo5 merged commit 249406e into master Aug 21, 2023
@andrebispo5 andrebispo5 deleted the auth/pm-3545-autofillbiometric branch August 21, 2023 19:30
andrebispo5 added a commit that referenced this pull request Aug 21, 2023
@andrebispo5
[PM-3545] Fix biometric unlock for autofill (#2710)
a973185 
* [PM-3545] Fix biometric unlock for autofill

* [PM-3545] Reuse existing method

Commit:
249406e [249406e]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlf0dev jlf0dev jlf0dev approved these changes

@fedemkr fedemkr Awaiting requested review from fedemkr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrebispo5 @bitwarden-bot @jlf0dev