[PM-3640] don't clear key needed for bio/auto migration in pin migration #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
trmartin4
pushed a commit
that referenced
this pull request
Aug 25, 2023
(cherry picked from commit 819aabb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
When migrating the pin, we were clearing the old encryption key. Unfortunately, this key is needed for the bio/auto migration that could still happen later.
This fix checks for the existence of an old encrypted master key inside the pin migration, indicating that the bio/auto migration is still needed, and doesn't clear the old encryption key if so. I have also added a null check to the bio/auto migration.
This will need to be picked to
rcCode changes
Screenshots
Before you submit
dotnet format --verify-no-changes) (required)