Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-3811] Passkeys unification #2774

Merged
merged 7 commits into from
Sep 22, 2023
Merged

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Sep 14, 2023

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Unify both passkeys to be displayed inside a Login cipher, also change the Login Fido2Key to be an array where the passkeys will be stored.

Code changes

  • Cipher/Data/Request/Response/View: Removed Fido2Key and added some helpers given that the passkeys will be stored inside the Login item.
  • Login/Data/Api: Changed Fido2Key to be an array and added some helpers inside to handle it easier. Also added MainFido2Key given that for the moment only one Fido2Key will exist in the array.
  • CipherAddEditPage/ViewModel / CipherDetailsPage/ViewModel: Unified to only display CreationDate as Passkey data.
  • CipherDetailsPageViewModel: Updated can clone logic.
  • Others: Updated logic for new array approach.

Screenshots

Cipher details Light

Cipher details Light

Cipher details Dark

Cipher details Dark

Cipher edition Light

Cipher edition Light

Cipher edition Dark

Cipher edition Dark

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@bitwarden-bot
Copy link

bitwarden-bot commented Sep 14, 2023

Logo
Checkmarx One – Scan Summary & Detailsf898eb3a-ff95-4e2a-af12-9fa44107b61f

No New Or Fixed Issues Found

@fedemkr fedemkr marked this pull request as ready for review September 15, 2023 17:45
@fedemkr fedemkr requested review from a team September 15, 2023 17:45
mpbw2
mpbw2 previously approved these changes Sep 15, 2023
# Conflicts:
#	src/App/Resources/AppResources.Designer.cs
#	src/App/Resources/AppResources.resx
@fedemkr fedemkr requested a review from mpbw2 September 20, 2023 20:25
@fedemkr fedemkr requested a review from a team September 21, 2023 20:30
@fedemkr fedemkr removed the needs-qa label Sep 22, 2023
@fedemkr fedemkr enabled auto-merge (squash) September 22, 2023 14:55
@fedemkr fedemkr merged commit a4a0d31 into master Sep 22, 2023
@fedemkr fedemkr deleted the vault/pm-3811/passkeys-view-unification branch September 22, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants