Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-4052] Fix vault timeout logic #2802

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

jlf0dev
Copy link
Member

@jlf0dev jlf0dev commented Sep 28, 2023

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Our logic for the isLocked method was only setting the user key if we were checking an inactive account. Fixed logic and added comments to communicate intention for future.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Detailsc91b6655-ef5d-4e6d-9b53-e1c9ecbb0808

No New Or Fixed Issues Found

@jlf0dev jlf0dev requested review from fedemkr and andrebispo5 October 3, 2023 13:45
@trmartin4 trmartin4 merged commit 21fc564 into master Oct 13, 2023
@trmartin4 trmartin4 deleted the auth/pm-4052/fix-vault-timeout branch October 13, 2023 17:41
@djsmith85 djsmith85 linked an issue Oct 25, 2023 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vault timeout option not respected on iOS
4 participants