Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-868] Re-open app to item could crash the app #2813

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

andrebispo5
Copy link
Contributor

@andrebispo5 andrebispo5 commented Oct 4, 2023

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Try fix the most reoccurring crash. If the app goes to background and there was an item open, when it comes to the foreground and tries to load the item again it could crash.
bitwarden/mobile#2794
bitwarden/mobile#2478

Code changes

Check for previous opened item before trying to load the vault list.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

Sorry, something went wrong.

@andrebispo5 andrebispo5 requested a review from fedemkr October 4, 2023 12:25
@bitwarden-bot
Copy link

bitwarden-bot commented Oct 4, 2023

Logo
Checkmarx One – Scan Summary & Detailsaffde73e-c3bb-43b2-a280-51d18c81d6b1

No New Or Fixed Issues Found

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@andrebispo5 andrebispo5 requested a review from fedemkr October 4, 2023 13:13
@andrebispo5 andrebispo5 merged commit b23f295 into master Oct 4, 2023
@andrebispo5 andrebispo5 deleted the auth/pm-868/get_list_crash branch October 4, 2023 14:48
@djsmith85 djsmith85 mentioned this pull request Oct 16, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application crashes on iOS when is opened to a vault item iOS app crashing on startup
3 participants