Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-3340] Update timeout action for users without master password. #2818

Merged
merged 12 commits into from
Nov 6, 2023

Conversation

andrebispo5
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Update settings screen vault timeout action cell UI to match designs.

Code changes

Add disable and description properties to SettingsPageListItem.
Add new UI cell to data template.

Screenshots

Screen.Recording.2023-10-11.at.12.57.30.mov

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@bitwarden-bot
Copy link

bitwarden-bot commented Oct 13, 2023

Logo
Checkmarx One – Scan Summary & Detailsb2c2e572-8b4c-4786-b0ec-83c71b0e5567

No New Or Fixed Issues Found

@andrebispo5 andrebispo5 requested a review from fedemkr October 13, 2023 11:47
Copy link
Member

@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, just two small improvements and all good 🎉

src/App/Utilities/BoolToColorConverter.cs Outdated Show resolved Hide resolved
src/App/Pages/Settings/SecuritySettingsPageViewModel.cs Outdated Show resolved Hide resolved
andrebispo5 and others added 2 commits October 18, 2023 09:46
@andrebispo5 andrebispo5 requested a review from fedemkr October 18, 2023 08:51
src/App/Styles/ControlTemplates.xaml Outdated Show resolved Hide resolved
@andrebispo5 andrebispo5 requested a review from fedemkr October 23, 2023 09:58
Copy link
Member

@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@andrebispo5 andrebispo5 merged commit 7a65bf7 into master Nov 6, 2023
@andrebispo5 andrebispo5 deleted the auth/pm-3340/timeout_update branch November 6, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants