Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Build workflow - Install OpenJDK 11 #2883

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Fix Build workflow - Install OpenJDK 11 #2883

merged 2 commits into from
Nov 27, 2023

Conversation

vgrassia
Copy link
Member

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR fixes the build workflow by installing Microsoft OpenJDK 11. Other various improvements have also been applied.

Code changes

  • .github/workflows/build.yml: Update actions. Update runner versions. Add step for installing Microsoft OpenJDK 11. Remove unnecessary shell keys. Remove old retrieve-secrets step and use our action.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@vgrassia vgrassia requested review from a team November 27, 2023 21:47
@vgrassia vgrassia self-assigned this Nov 27, 2023
fedemkr
fedemkr approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome! 🎉

@vgrassia vgrassia marked this pull request as ready for review November 27, 2023 22:13
@vgrassia vgrassia merged commit ba5fa8a into master Nov 27, 2023
10 checks passed
@vgrassia vgrassia deleted the fix-build-workflow-openjdk branch November 27, 2023 22:18
vgrassia added a commit that referenced this pull request Nov 28, 2023
@vgrassia
Fix Build workflow - Install OpenJDK 11 (#2883)
11348e6 
(cherry picked from commit ba5fa8a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimartin12 mimartin12 mimartin12 approved these changes

@fedemkr fedemkr fedemkr approved these changes

Assignees

@vgrassia vgrassia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vgrassia @fedemkr @mimartin12