Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tools ownership for store/google/Publisher #2890

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

djsmith85
Copy link

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

The @bitwarden/team-tools-dev is getting asked for a review of bitwarden/mobile#2545. This adds an exception to the ownership of store/google/Publisher

Code changes

  • .github/CODEOWNERS: Add store/google/Publisher to the existing Locales exception.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@djsmith85 djsmith85 enabled auto-merge (squash) December 6, 2023 12:26
@djsmith85 djsmith85 requested a review from a team December 6, 2023 12:26
@bitwarden-bot
Copy link

bitwarden-bot commented Dec 6, 2023

Logo
Checkmarx One – Scan Summary & Detailsd41e50bb-33ec-4bff-b13f-1d87a8aca1e1

No New Or Fixed Issues Found

Co-authored-by: Federico Maccaroni <fedemkr@gmail.com>
@djsmith85 djsmith85 requested review from fedemkr and removed request for a team December 6, 2023 12:54
@djsmith85 djsmith85 merged commit 9c0908f into master Dec 6, 2023
9 checks passed
@djsmith85 djsmith85 deleted the djsmith85-patch-1 branch December 6, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants