[PM-6309] Fix for 'Show website icons' option not being respected #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is updated correctly based on website icons visibility choice
fedemkr
approved these changes
Feb 26, 2024
dinisvieira
deleted the
feature/PM-6309-fix-for-website-icons-choice-not-respected
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Type of change
Objective
'Show website icons' option is not being respected.
Code changes
The issue seems to be caused by the
Icon_Successsetting Icon to visible after loading it without taking into account the current WebsiteIcons setting.Icon_Successmethod to take into account the current WebsiteIcons setting.Screenshots
Before you submit
dotnet format --verify-no-changes) (required)