Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-5916] Fix for incorrect fonts in fingerprint phrases #3042

Merged

Conversation

dinisvieira
Copy link

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fingerprint phrases are being shown with the incorrect font

Code changes

The correct font is set for MonoLabel but apparently they are not set when using FormattedText.
Changing to Text instead fixes the issue. (FormattedText doesn't really seem to be needed in this scenario)
I applied this to other MonoLabel in the app that had the same issue.

  • LoginPasswordlessPage.xaml: Changed FormattedText to Text
  • LoginPasswordlessRequestPage.xaml: Changed FormattedText to Text
  • LoginPasswordlessRequestsListPage.xaml: Changed FormattedText to Text

Screenshots

Before After
Before After

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@dinisvieira dinisvieira requested a review from a team as a code owner February 28, 2024 19:09
Copy link
Contributor

@andrebispo5 andrebispo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@dinisvieira dinisvieira merged commit 4ff56ba into main Feb 29, 2024
13 checks passed
@dinisvieira dinisvieira deleted the feature/PM-5916-incorrect-font-in-fingerprint-phrases branch February 29, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants