Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-6552] Fix for Android Window issues when opening Autofill/Accessibility #3051

Conversation

dinisvieira
Copy link

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

There are still several edge cases in which the app should try to execute the navigation after showing the HomePage and doesn't.
As an alternative we are trying to always try to Navigate when CreateWindow is launched on Android.

Code changes

Removed several of the Window Workarounds for Android. Now always relying on the AndroidNavigationRedirectPage
AndroidNavigationRedirectPage now more resilient to failure and navigates to HomePage as fallback.

  • App.xaml.cs: Removed a lot of the previous workarounds which should now be replaced with just using always AndroidNavigationRedirectPage
  • AndroidNavigationRedirectPage.xaml.cs: Made redirection a bit more resilient and with fallback to just Navigate to HomePage
  • AutofillSettingsPageViewModel.android.cs: Removed previous workaround for Accessibility Settings as it's no longer need
  • ResumeWindow.cs: AutofillWindow and MainWindow is no longer needed as we don't reuse or differentiate anymore

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

…ways relying on the AndroidNavigationRedirectPage.

AndroidNavigationRedirectPage now more resilient to failure and navigates to HomePage as fallback.
@dinisvieira dinisvieira requested a review from fedemkr March 3, 2024 15:29
@dinisvieira dinisvieira requested a review from a team as a code owner March 3, 2024 15:29
Copy link
Member

@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉 Just one minor improvement

Co-authored-by: Federico Maccaroni <fedemkr@gmail.com>
@dinisvieira dinisvieira merged commit 40c80f0 into main Mar 4, 2024
6 of 10 checks passed
@dinisvieira dinisvieira deleted the feature/PM-6552-fix-for-launching-app-after-accessibility-settings branch March 4, 2024 13:03
@kubo6472
Copy link

This broke autofill QS tile for me :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants