Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEVOPS-1866 - Fix F-Droid Signing #3063

Merged
merged 3 commits into from
Mar 7, 2024
Merged

DEVOPS-1866 - Fix F-Droid Signing #3063

merged 3 commits into from
Mar 7, 2024

Conversation

vgrassia
Copy link
Member

@vgrassia vgrassia commented Mar 7, 2024

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR fixes the F-Droid signing process.

Code changes

  • .github/workflows/build.yml: Update steps so that the F-Droid APK is signed properly.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@vgrassia vgrassia self-assigned this Mar 7, 2024
@vgrassia vgrassia requested a review from a team as a code owner March 7, 2024 23:42
@vgrassia vgrassia enabled auto-merge (squash) March 7, 2024 23:43
@vgrassia vgrassia merged commit e344184 into main Mar 7, 2024
12 checks passed
@vgrassia vgrassia deleted the devops-1866_fix-fdroid-signing branch March 7, 2024 23:45
vgrassia added a commit that referenced this pull request Mar 7, 2024
@vgrassia
DEVOPS-1866 - Fix F-Droid Signing (#3063)
8df54c1 
(cherry picked from commit e344184)
@djsmith85 djsmith85 linked an issue Mar 8, 2024 that may be closed by this pull request
com.x8bit.bitwarden-fdroid.apk Version 2024.2.1 signature issues #3062
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseph-flinn joseph-flinn joseph-flinn approved these changes

Assignees

@vgrassia vgrassia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

com.x8bit.bitwarden-fdroid.apk Version 2024.2.1 signature issues
2 participants
@vgrassia @joseph-flinn