Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-6751]Added missing query intent for CustomTabs that might be responsible for the Exception in WebAuthenticator #3071

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

dinisvieira
Copy link

@dinisvieira dinisvieira commented Mar 10, 2024

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

There's a NullPointerException ocurring in WebAuthenticatorIntermediateActivity.
This is likely related with WebAuthenticatorCallbackActivity in Android.
As explained in the Microsoft Docs when using this WebAuthenticator on Android we need to add the appropriate query.
This might be the cause of the bug.

<queries>
    <intent>
        <action android:name="android.support.customtabs.action.CustomTabsService" />
    </intent>
</queries>

Code changes

Added the query intent for CustomTabs as it might fix the exception that is occurring in Android WebAuthenticator.

  • AndroidManifest.xml: Added the query

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@vvolkgang vvolkgang changed the title Added missing query intent for CustomTabs that might be responsible for the Exception in WebAuthenticator [PM-6751] Added missing query intent for CustomTabs that might be responsible for the Exception in WebAuthenticator Mar 11, 2024
@vvolkgang vvolkgang changed the title [PM-6751] Added missing query intent for CustomTabs that might be responsible for the Exception in WebAuthenticator [PM-6751][PM-6752] Added missing query intent for CustomTabs that might be responsible for the Exception in WebAuthenticator Mar 11, 2024
@vvolkgang vvolkgang changed the title [PM-6751][PM-6752] Added missing query intent for CustomTabs that might be responsible for the Exception in WebAuthenticator [PM-6751]Added missing query intent for CustomTabs that might be responsible for the Exception in WebAuthenticator Mar 11, 2024
@fedemkr fedemkr merged commit d1e82c9 into main Mar 11, 2024
16 checks passed
@fedemkr fedemkr deleted the bug/crash-using-webauthentication-android branch March 11, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants