Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7010] Fix for Android App crashing when launching app with invalid package name #3092

Merged

Conversation

dinisvieira
Copy link

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Android App is currently crashing when launching a package name that is not found on the device.

Code changes

Added specific Exception Try Catch to avoid crashing when the package name is not found.
IntentSender.SendIntentException is the Exception we get in Debug when trying to launch an invalid package name.
Android.Util.AndroidException is an Exception that seems to be reported on AppCenter for the same issue.

  • DeviceActionService: Added the specific TryCatch

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

Sorry, something went wrong.

…ng when trying to launch app package name that are not installed on the device.
@dinisvieira dinisvieira requested a review from fedemkr March 17, 2024 23:44
@dinisvieira dinisvieira requested a review from a team as a code owner March 17, 2024 23:44
Copy link
Member

@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just in case @mpbw2 could you take a look as well? in case I'm missing something on these specific exceptions that could be useful for us to have logged.

@fedemkr fedemkr requested a review from mpbw2 March 18, 2024 13:52

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ackage-name
@vvolkgang vvolkgang changed the title Fix for Android App crashing when launching app with invalid package name [PM-7010] Fix for Android App crashing when launching app with invalid package name Mar 22, 2024
@dinisvieira dinisvieira merged commit f04ff77 into main Mar 22, 2024
14 checks passed
@dinisvieira dinisvieira deleted the bug/android-exception-launch-app-incorrect-package-name branch March 22, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants