[PM-16670] Force app to sync after 2FA notice #4525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrebispo5
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront,
phil-livefront and
a team
as code owners
|
New Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2024.12-rc13 #4525 +/- ##
=======================================================
Coverage ? 88.88%
=======================================================
Files ? 460
Lines ? 39920
Branches ? 5686
=======================================================
Hits ? 35483
Misses ? 2459
Partials ? 1978 ☔ View full report in Codecov by Sentry. |
| @@ -172,6 +172,7 @@ class NewDeviceNoticeTwoFactorViewModelTest : BaseViewModelTest() { | |||
| authRepository = authRepository, | |||
| environmentRepository = environmentRepository, | |||
| featureFlagManager = featureFlagManager, | |||
| settingsRepository = mockk(relaxed = true), | |||
There was a problem hiding this comment.
Can we make a variable for this so we can test when the repo is called.
| @@ -170,6 +170,7 @@ class AuthRepositoryTest { | |||
| private val vaultRepository: VaultRepository = mockk { | |||
| every { vaultUnlockDataStateFlow } returns mutableVaultUnlockDataStateFlow | |||
| every { deleteVaultData(any()) } just runs | |||
| every { syncIfNecessary() } just runs | |||
There was a problem hiding this comment.
We should also be verifying that syncIfNecessary is being called in the correct spot.
david-livefront
approved these changes
Jan 8, 2025
# Conflicts: # app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/newdevicenotice/NewDeviceNoticeTwoFactorViewModel.kt # app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/newdevicenotice/NewDeviceNoticeTwoFactorViewModelTest.kt
andrebispo5
added a commit
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16670
📔 Objective
We need the app to sync when the user leaves the app to setup a two factor method and comes back. This will void the grace period of 30 mins between vault syncs.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes