[PM-16808] Add question mark to copy #4544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrebispo5
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront,
phil-livefront and
a team
as code owners
|
New Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2024.12-rc13 #4544 +/- ##
=======================================================
Coverage ? 88.88%
=======================================================
Files ? 460
Lines ? 39933
Branches ? 5688
=======================================================
Hits ? 35496
Misses ? 2459
Partials ? 1978 ☔ View full report in Codecov by Sentry. |
david-livefront
approved these changes
Jan 9, 2025
| @@ -1089,7 +1089,7 @@ Do you want to switch to this account?</string> | |||
| <string name="copy_address">Copy address</string> | |||
| <string name="important_notice">Important notice</string> | |||
| <string name="bitwarden_will_soon_send_a_code_to_your_account_email_to_verify_logins_from_new_devices_in_february">Bitwarden will send a code to your account email to verify logins from new devices starting in February 2025.</string> | |||
| <string name="do_you_have_reliable_access_to_your_email">Do you have reliable access to your email, <annotation emphasis="bold"><annotation arg="0">%1$s?</annotation></annotation></string> | |||
| <string name="do_you_have_reliable_access_to_your_email">Do you have reliable access to your email, <annotation emphasis="bold"><annotation arg="0">%1$s?</annotation></annotation>?</string> | |||
There was a problem hiding this comment.
I approved because the question mark if fine, but I don't think we can use annotations in the strings since Crowdin strips them out. I don't think this will work in other languages. Can we update the app to use spannables
There was a problem hiding this comment.
I was pretty sure that it was using the spannables.
I think this was introduced in @dseverns-livefront 's PR: https://github.com/bitwarden/android/pull/4479/files#diff-5e01f7d37a66e4ca03deefc205d8e7008661cdd0284a05aaba1858e6b7bf9103L1103
There was a problem hiding this comment.
OK, we might need to look into it. Normally I have no issue with the annotations but I am unsure if Crowdin is parsing it properly.
andrebispo5
added a commit
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16808
📔 Objective
Add missing question mark to label: "Do you have reliable access to your email, ... ?"
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes