Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasteboard type #2633

Closed
michalwski opened this issue May 21, 2018 · 52 comments · Fixed by #11025
Closed

Pasteboard type #2633

michalwski opened this issue May 21, 2018 · 52 comments · Fixed by #11025
Labels
desktop Desktop Application

Comments

@michalwski
Copy link

I'd like to exclude Bitwarden from clipboard menu application like (Flycut). To do that I need to now what pasteboard type is used. According to this issue: #326 it looks like this should be possible with the desktop version, is it?

@kspearrin
Copy link
Member

How do I view what the clipboard value's pasteboard type is? I installed Flycut but i don't see anything that tells what the pastebaord type of each thing I copied is.

@michalwski
Copy link
Author

Flycut can be configured to exclude given pasteboard types. The default value it excludes is: PasswordPboardType. You can see it in preferences. Hope that helps.

@kspearrin
Copy link
Member

Unfortunately I am not seeing an API in electron for defining the Pasteboard Type during clipboard write functions. https://electronjs.org/docs/api/clipboard#clipboardwritetexttext-type

There is a "type" parameter, but that doesn't seem related to the Pasteboard type, since all still seem to written as NSStringPboardType.

@goncalossilva
Copy link

goncalossilva commented Mar 15, 2020

They are marked as experimental APIs, but this should work, where format is org.nspasteboard.ConcealedType.

@kspearrin
Copy link
Member

Thanks @goncalossilva . We'll keep an eye on this API.

@3zero2
Copy link

3zero2 commented Aug 26, 2020

Have there been any updates about this by any chance?

@Stickyhavr
Copy link

How do I view what the clipboard value's pasteboard type is?

One option is: https://github.com/sindresorhus/Pasteboard-Viewer

I found that info here: p0deje/Maccy#125

I would love to be able to exclude BitWarden from Maccy. Hope this gets resolved someday. Thanks

@3zero2
Copy link

3zero2 commented Aug 29, 2020

Bitwarden only returns public.utf8-plain-text as the NSPasteboard type. I think that adding this to Flycut or Maccy would actually filter out not only Bitwarden but a bunch of other apps as well.

@Stickyhavr
Copy link

Yes, it would. That's why it would be best for BitWarden to use a particular pasteboard type that's not plain text. Either something like org.nspasteboard.ConcealedType or its own unique identifier. I don't know much about all of that, but there seems to be a list of some types here: http://nspasteboard.org/

@krabf
Copy link

krabf commented Oct 25, 2020

Any updates on this? I'm also using Macccy and would love to exclude Bitwarden

@3zero2
Copy link

3zero2 commented Oct 25, 2020

No updates as far as I know.

@rraihansaputra
Copy link

Hi @kspearrin, apologies for the ping, but is there any update about the clipboard.writeBuffer API usage? The Electron docs still marks them as experimental, and the Bitwarden app still outputs NSStringPboardType (checked from Flycut).

@Stickyhavr
Copy link

I still have my fingers crossed this will show up someday.

@mcotse
Copy link

mcotse commented Apr 2, 2021

Any updates? Would love to keep using Bitwarden and have proper integration with various clipboard managers 🙏

@webdev69420
Copy link

webdev69420 commented Aug 31, 2021

Any updates?

@eliykat
Copy link
Member

eliykat commented Sep 1, 2021

This has been triaged and is in our backlog, but does not have any specific deadline for a fix.
That said, last I looked into it, the Electron and Browser APIs that let us set the pasteboard type are all marked as experimental. In particular, FF has limited support for the ClipboardItem and Clipboard.write APIs required. I think there's more danger in implementing this in an inconsistent or unreliable fashion than waiting for the API support to catch up.

@bckp
Copy link

bckp commented Nov 1, 2021

Maybe @kspearrin, @eliykat this can be implemented in some: experimental feature in BW itself... so users need to enable that explicitly. That will help mac users that use Maccy (still do not undestand Apple do not implementet this directly) and if everythink goes wrong, you can just unckeck one option.

@webdev69420
Copy link

Has there been any new developments concerning this issue?

@spinlud
Copy link

spinlud commented Mar 20, 2022

+1. Shouldn't this be put in priority? It seems a concerning security risk for anyone using the extension and a clipboard manager 😮

@tomasherman
Copy link

tomasherman commented Apr 24, 2022

for what it's worth - a workaround for Alfred users, you can set up alfred to ignore clipboard entries from certain apps - for example bitwarden :) This almost forced me to go back to 1password, luckily i found this workaround :)

image

note that if you copy something from browser extension, it is still stored in alfred :(

@Stickyhavr
Copy link

Stickyhavr commented Apr 24, 2022 via email

@tomasherman
Copy link

BTW this also affects credit card numbers, which to me is even worse than passwords altho of course passwords are bad enough. I wonder how/if other password managers address this in the browser extension.

@tomasherman
Copy link

One more idea - until a proper fix can be made, i would be satisfied with option to disable copy-from-webextension. This would force me to use app and that I can put into ignore list. This would solve the worry i have of accidentaly copying sensitive info into clipboard from the web extension without realising it.

@Hinton Hinton added the desktop Desktop Application label May 5, 2022
@Hinton Hinton transferred this issue from bitwarden/desktop May 5, 2022
@exploitJ
Copy link

exploitJ commented Nov 7, 2022

any updates? this can be a serious vulnerability.

@Ashiro12138
Copy link

for what it's worth - a workaround for Alfred users, you can set up alfred to ignore clipboard entries from certain apps - for example bitwarden :) This almost forced me to go back to 1password, luckily i found this workaround :)
...
note that if you copy something from browser extension, it is still stored in alfred :(

Same issue here.
My clipboard manager (Maccy) allows me to exclude certain applications and it works fine when I'm copying directly from the app itself. But when I copy something from the browser extension it'll still be recorded.
As of 12/06/2023 bitwarden is still returning public.utf8-plain-text for passwords.
Are there any updates on this?

@paulrudy
Copy link

This has been an issue for 5 years now. Could one of the Bitwarden maintainers please explain why this issue is not considered a priority?

@mtzfox
Copy link

mtzfox commented Jun 14, 2023

This has been an issue for 5 years now. Could one of the Bitwarden maintainers please explain why this issue is not considered a priority?

Second this!

@dbosompem
Copy link

Hi everyone, apologies for leaving this hanging for a while. I must admit this almost got lost in the midst of other high priority work. We are discussing internally the path forward, and I will be sure to share with the community any findings. Thank you for your patience as we look into this!

@bluekeybo
Copy link

@dbosompem any update on this? We'd really appreciate it, as it will enhance the user experience and security for those who use a clipboard manager. Thank you!

@thomasdemoner
Copy link

Hi everyone, apologies for leaving this hanging for a while. I must admit this almost got lost in the midst of other high priority work. We are discussing internally the path forward, and I will be sure to share with the community any findings. Thank you for your patience as we look into this!

Any findings?

@mvevitsis
Copy link

mvevitsis commented Jan 18, 2024

@dbosompem How on earth is this obvious security risk not fixed already?

@fooness
Copy link

fooness commented Feb 8, 2024

Hi everyone, apologies for leaving this hanging for a while. I must admit this almost got lost in the midst of other high priority work. We are discussing internally the path forward, and I will be sure to share with the community any findings. Thank you for your patience as we look into this!

@dbosompem This was many months ago. Please, share your findings and the path forward.

@Xytronix
Copy link

@Hinton can we expect an update soon?

@1vishen
Copy link

1vishen commented Mar 26, 2024

Hoping there would be an update soon, I’ve been using Maccy, which ignores the Bitwarden app but not the browser extension. The extension is much more convenient.

@romajmg
Copy link

romajmg commented Apr 17, 2024

bump

@Xytronix
Copy link

Xytronix commented Apr 17, 2024

@dbosompem This feature was requested 6 years ago and well received by anyone here.
Can we get an update asap?

@zer0cee
Copy link

zer0cee commented May 10, 2024

+1

@samundra
Copy link

+1, coming from developer background, I can see why it's being delayed. Lets have some patience and wait for experimental browser API to become stable first. Then we can expect it to be implemented into Bitwarden.

@ilyagr
Copy link

ilyagr commented May 17, 2024

If it's true that the app does this correctly, one possible work-around would be heavy-handed, but might be worth it: have the extension ask the Bitwarden app to do the actual copying to the clipboard.

This would of course only work if the app is running. The extension and the app can already communicate for the biometric verification, though of course there are many technical details I would be unaware of that could potentially make my suggestion difficult or impossible to implement.


Update: No, the Bitwarden app does not set the pasteboard type on MacOS either, it's not just the extension. (Or rather, it's set to public.utf8-plain-text) This would be nice and likely easier to fix, but see also the above comment #2633 (comment) for possible obstacles.

However, regardless of the pasteboard type, a clipboard manager like Maccy can be told to ignore copies coming from the Bitwarden app, and perhaps could change the default config to do it by default, so having the copy come from the app would still be helpful.

@colineberly
Copy link

+1, coming from developer background, I can see why it's being delayed. Lets have some patience and wait for experimental browser API to become stable first. Then we can expect it to be implemented into Bitwarden.

Patience... if 6 years isn't patience, I dunno what is.

@mBeded-Studios
Copy link

Bump. Just downloaded a clipboard manager, maccy, and realizing this is really unsafe to use with the chrome extension which i use daily.

@mvevitsis
Copy link

It is insane that this has not been fixed after all this time

@TickDracy
Copy link

Hi everyone, apologies for leaving this hanging for a while. I must admit this almost got lost in the midst of other high priority work. We are discussing internally the path forward, and I will be sure to share with the community any findings. Thank you for your patience as we look into this!

Hello, is there any update regarding this?

@paulrudy
Copy link

paulrudy commented Aug 1, 2024

I moved to a MacOS/iOS app that works with KeepassX databases because of this issue specifically.

@TickDracy
Copy link

TickDracy commented Aug 1, 2024

I moved to a MacOS/iOS app that works with KeepassX databases because of this issue specifically.

I, personally, prefer Bitwarden, given that it's been great until now. I even decided to purchase Premium to support them (even though I don't need any of the Premium features). But using Maccy app on macOS alerted me to this bug and seeing that it's open since 2018, I don't have too much hope that it will be fixed.

But I'm open to considering other alternatives with multi-system integration (Windows, macOS, Linux and iOS), given that's necessary for me. So please, feel free to recommend them!

@mvevitsis
Copy link

Neither keepass nor 1password have this problem.

@Xytronix
Copy link

Xytronix commented Aug 1, 2024

Neither keepass nor 1password have this problem.

@mvevitsis could you explain this further? Does 1Password browser extension copy from the desktop app?

@mvevitsis
Copy link

They both have their own pasteboard type. Bitwarden doesn't.

@paulrudy
Copy link

paulrudy commented Aug 1, 2024

But I'm open to considering other alternatives with multi-system integration (Windows, macOS, Linux and iOS), given that's necessary for me. So please, feel free to recommend them!

I'm using Strongbox (iOS/MacOS) and I've been very happy with it for the past few months. It uses the open source KeepassX database format, easily imports Bitwarden and other formats, and you can get clients for KeepassX which are compatible with Windows and Linux

@Hinton
Copy link
Member

Hinton commented Sep 16, 2024

Hi everyone,

The original issue for MacOS Pasteboard types is resolved in #11025. Please note this is only for MacOS in the desktop client. For linux the team is tracking an upstream issue but the ecosystem is more fragmented with multiple standards. For browser related issues please use one of the existing issues, but note we are limited by the available capabilities on the platform and browsers do not currently offer any APIs for excluding clipboard items from history

This should be available in an upcoming release in about a months time. Please note it will not be part of this month's release.

@miguelarios
Copy link

@Hinton i don't follow if this will be addressed in the Bitwarden extension as well as that seems to not have a workaround with clipboard managers. With Alfred for instance you can ignore Bitwarden desktop and that clears it at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Desktop Application
Projects
None yet
Development

Successfully merging a pull request may close this issue.