[PM-10105] Release arm64 binaries for macOS #10273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
changed the title
jomifepe
force-pushed
the
feat/release-macos-arm64-binary
branch
from
04081d8
to
00fd417
Compare
jomifepe
force-pushed
the
feat/release-macos-arm64-binary
branch
from
00fd417
to
e9e691b
Compare
jomifepe
force-pushed
the
feat/release-macos-arm64-binary
branch
from
e9e691b
to
45227aa
Compare
|
I hope this doesn't get ignored like the previous attempts. I know the CLI is low priority, but is there any other reason why this would not be desirable? |
… into feat/release-macos-arm64-binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://github.com/orgs/bitwarden/discussions/10219
Other related discussions:
Other pending contributions:
📔 Objective
It has been years since arm64 became the standard for macs, and this PR aims to tweak the build ci workflow to release those. It releases two new binaries:
bw-macos-arm64-*.zipandbw-oss-macos-arm64-*.zip.It uses
macos-14github runner to build the binaries.Here is a successful run of this new build script for reference: https://github.com/jomifepe/clients/actions/runs/10050097941.
Who benefits from this?
Everyone who wants to install the CLI on modern macOS (e.g. macbooks since 2020). The official site points you to
npmfor arm64, requiring you to install node, but makesx64binaries available to download.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes