-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-10128] [BEEEP] Add Right-Click Menu Options to Vault #10954
Draft
gbubemismith
wants to merge
20
commits into
main
Choose a base branch
from
beep/right-click-cipher-row
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+271
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #10954 +/- ##
==========================================
- Coverage 33.48% 33.48% -0.01%
==========================================
Files 2846 2846
Lines 89196 89234 +38
Branches 17002 17014 +12
==========================================
+ Hits 29867 29878 +11
- Misses 56976 57002 +26
- Partials 2353 2354 +1 ☔ View full report in Codecov by Sentry. |
gbubemismith
changed the title
[PM-10128]
[PM-10128] Add Right-Click Menu Options to Vault
Sep 9, 2024
gbubemismith
changed the title
[PM-10128] Add Right-Click Menu Options to Vault
[PM-10128] [BEEEP] Add Right-Click Menu Options to Vault
Sep 9, 2024
Added new copy options for the other cipher types Simplified the copy by using the copy cipher field directive
…ients into beep/right-click-cipher-row
…nctions would not be needed anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-10128
📔 Objective
Implement a context menu that appears on right-click within the end user vault, providing quick access to relevant actions and options
📸 Screenshots
Screen.Recording.2024-11-15.at.12.02.59.PM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes