Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-13820] Add class to remove link underline #11762

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

vleague2
Copy link
Contributor

@vleague2 vleague2 commented Oct 28, 2024

๐ŸŽŸ๏ธ Tracking

PM-13820

๐Ÿ“” Objective

This PR adds an explicit class to the link directive to remove underline. Some clients and default browser stylesheets add an underline, so we can't rely on no underline being the default state.

๐Ÿ“ธ Screenshots

Before After
Screenshot 2024-10-28 at 5 45 30โ€ฏPM Screenshot 2024-10-28 at 5 41 35โ€ฏPM

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Please upload report for BASE (ps/extension-refresh@4f1becf). Learn more about missing BASE report.
Report is 9 commits behind head on ps/extension-refresh.

โœ… All tests successful. No failed tests found.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             ps/extension-refresh   #11762   +/-   ##
=======================================================
  Coverage                        ?   33.56%           
=======================================================
  Files                           ?     2810           
  Lines                           ?    87367           
  Branches                        ?    16653           
=======================================================
  Hits                            ?    29325           
  Misses                          ?    55740           
  Partials                        ?     2302           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@vleague2 vleague2 marked this pull request as ready for review October 28, 2024 21:47
@vleague2 vleague2 requested a review from a team as a code owner October 28, 2024 21:47
@vleague2 vleague2 merged commit 5ea71ad into ps/extension-refresh Oct 29, 2024
67 checks passed
@vleague2 vleague2 deleted the ds/pm-13820/link-underline branch October 29, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants