[CL-500] Add disclosure component and directive #11865
Merged
+152
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11865 +/- ##
==========================================
- Coverage 33.59% 33.59% -0.01%
==========================================
Files 2825 2829 +4
Lines 88289 88310 +21
Branches 16834 16835 +1
==========================================
+ Hits 29658 29665 +7
- Misses 56308 56322 +14
Partials 2323 2323 ☔ View full report in Codecov by Sentry. |
willmartian
reviewed
Nov 5, 2024
vleague2
changed the title
vleague2
requested review from
merissaacosta and
willmartian
and removed request for
merissaacosta
danielleflinn
previously approved these changes
Nov 6, 2024
There was a problem hiding this comment.
✅ Verified default, hover, selected, and focus styles match Figma
✅ Verified SR announcements with VO in Chrome match Figma
✅ Verified on click content his shown/hidden
Should we call out in the Disclosure docs "Accessibility" section to be sure to still follow the accessibility guidelines for the button/icon-button triggering the element? (I'm specifically thinking of the icon-button here hoping folks wont' forget to use the appA11yTitle)
willmartian
reviewed
Nov 6, 2024
libs/components/src/disclosure/disclosure-trigger-for.directive.ts
Outdated
Show resolved
Hide resolved
vleague2
force-pushed
the
ds/cl-500/icon-button-toggle
branch
from
fdb0434
to
42f9779
Compare
vleague2
dismissed stale reviews from willmartian and danielleflinn
The base branch was changed.
|
Rebased to |
willmartian
approved these changes
Nov 7, 2024
|
Fixed Issues
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
CL-500
📔 Objective
This PR adds a
disclosurecomponent and accompanying directive that controls the disclosure's visibility. It also addsicon-buttonstyling to handle the appearance of themutedvariant button when its disclosure area is expanded. (This functionality is not behind a feature flag, but will only affect icon buttons used with the disclosure.)Changes to the
icon-buttondocumentation files are remnants of a prior approach, but they still improve the documentation so I'm leaving them in here.📸 Screenshots
Screen.Recording.2024-11-06.at.10.44.06.AM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes