[PM-14627] totp secret is assigned to cipher object in zohovalut-csv-importer to…

[kshashikumar]

… populate when importing keys from zoho vault fixes #11872 closes #11872

🎟️ Tracking

📔 Objective

totp secret is assigned to cipher object in zohovalut-csv-importer to populate when importing keys from zoho vault fixes #11872 closes #11872

📸 Screenshots

Before

After

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[CLAassistant]

All committers have signed the CLA.

[bitwarden-bot]

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-14627
Link: https://bitwarden.atlassian.net/browse/PM-14627

[djsmith85]

@kshashikumar Thank you for your contribution 🚀

Your changes are looking good. I just tested and you can actually simply assign the full login_totp to cipher.login.totp. This has the benefit of retaining all information (secret, algorithm and period)

Would you be willing to also add unit tests for this or even for the full zohovalut-csv-importer?

Unfortunately this specific importer has no unit tests yet, but examples can be found within libs/importer/spec.

Kind regards,
Daniel

[kshashikumar]

Thank you for the review @djsmith85, will update the cipher.login.totp to take full url and also will add unit tests for it. Thanks again

[kshashikumar]

Hi @djsmith85 , updated cipher.login.totp to take full totp url and also implemented unit tests for above. Please let me know if any further changes needed. Thank you for your time and consideration.