-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/register does not redirect to /signup when email-verification flag is enabled #12001
Open
alec-livefront
wants to merge
5
commits into
main
Choose a base branch
from
auth/pm-13897/redirect-register-to-signup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12001 +/- ##
=======================================
Coverage 33.49% 33.49%
=======================================
Files 2846 2846
Lines 89196 89198 +2
Branches 17002 17004 +2
=======================================
+ Hits 29874 29876 +2
Misses 56969 56969
Partials 2353 2353 ☔ View full report in Codecov by Sentry. |
Fixed Issues
|
…ture flag is enabled" This reverts commit f3a2b41.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13897?atlOrigin=eyJpIjoiYTA3YWJlZGJjMjdjNGI4NWI1YjUxOWI3Njk4Y2FhNTEiLCJwIjoiaiJ9
📔 Objective
Instead of usingcanAccessFeature
to check the feature flag and redirect (it shows a toast error when redirecting, which we don't want), check the feature flag and redirect manually.Alternatively, we could:- modifycanAccessFeature
to take another argument to conditionally disable the toast- create our own version ofcanAccessFeature
that doesn't show a toastModifies
canAccessFeature
to take another argument to conditionally disable the toast. Now visiting/register
when theEmailVerification
feature flag is on will redirect a user to/signup
without showing a toast error.📸 Screenshots
GMT20241114-211641_Clip_Alec.Rippberger.s.Clip.11_14_2024.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes