[PM-14473] AC - "New" item button

[nick-livefront]

🎟️ Tracking

PM-14473

📔 Objective

The ticket is geared towards custom users that cannot create a collection. Those users were only seeing the "new item" button rather than the dropdown to select the cipher type.

This was caused by the hierarchy of logic favoring the user's permissions rather than the extension refresh first. To solve:

• I moved the check for extension refresh up, so the user will always see the dropdown menu unless they can only create collection¹.
  • This does create a little but of duplicate markup, but it will be easy to strip out the non-refresh code once that is enabled.
• There is internal logic within the dropdown menu to properly show the available options respective of the permissions.

¹ I wasn't able to find permissions to test this scenario. Is there a way to get a user who can only create collections?

📸 Screenshots

custom-user-create-cipher.mov

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.44%. Comparing base (a415679) to head (7cfc1be).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #12002   +/-   ##
=======================================
  Coverage   33.44%   33.44%           
=======================================
  Files        2845     2845           
  Lines       89099    89099           
  Branches    16992    16992           
=======================================
  Hits        29803    29803           
  Misses      56950    56950           
  Partials     2346     2346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – 5b42060e-2bc7-4ec6-98fd-eabd7a0dbc6f

No New Or Fixed Issues Found