Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13192] [Defect] - Account Security settings not converted to use bit-select #12008

Merged

Conversation

alec-livefront
Copy link
Collaborator

@alec-livefront alec-livefront commented Nov 14, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13192?atlOrigin=eyJpIjoiNTRiMzdkZjdiNGFiNDk4NWFhNjY3YmQ4ZjZkM2YwN2QiLCJwIjoiaiJ9

📔 Objective

Converts the select on the Account Security Settings page to a bit-select.

📸 Screenshots

GMT20241115-171002_Clip_Alec.Rippberger.s.Clip.11_15_2024.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.48%. Comparing base (0308e6e) to head (2e805dc).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12008   +/-   ##
=======================================
  Coverage   33.48%   33.48%           
=======================================
  Files        2846     2846           
  Lines       89196    89196           
  Branches    17002    17002           
=======================================
  Hits        29867    29867           
  Misses      56976    56976           
  Partials     2353     2353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Logo
Checkmarx One – Scan Summary & Detailsf8fd7070-30bc-49dd-944f-3b9b547fdc3d

No New Or Fixed Issues Found

Copy link
Contributor

@quexten quexten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side but I'm not an auth codeowner anymore.

@alec-livefront alec-livefront merged commit be61d5d into main Nov 18, 2024
27 checks passed
@alec-livefront alec-livefront deleted the auth/pm-13192/defect-convert-select-on-account-security branch November 18, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants