-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: UI for multiple totp elements #12404
enhancement: UI for multiple totp elements #12404
Conversation
New Issues
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12404 +/- ##
=======================================
Coverage 33.50% 33.50%
=======================================
Files 2916 2917 +1
Lines 91158 91168 +10
Branches 17351 17349 -2
=======================================
+ Hits 30540 30546 +6
- Misses 58211 58221 +10
+ Partials 2407 2401 -6 ☔ View full report in Codecov by Sentry. |
…e-matching-logins
apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One non-blocking nit, otherwise LGTM (I smoke-tested as well). Thank you!
…ill-inline-menu-list.ts Co-authored-by: Jonathan Prusik <jprusik@users.noreply.github.com>
bdd11dc
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15437
📔 Objective
When there are multiple totp inline menu elements rendered for the same login, display the username for that login
Changes:
multipleTotpElements
method, I took the approach of filtering ciphers that have both totp codes and are a totpField, if the length is greater than 1 return truemultipleTotpElements
method to set a condition which will render and display the username📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes