Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict typescript for Component Library stories #12423

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Dec 16, 2024

🎟️ Tracking

📔 Objective

Fixing some low hanging fruits for moving CL to strict typescript.

This primarily removes the types from args since TS infers them differently. We previously needed them since storybook would use any for args but now provides proper typings.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from a team as a code owner December 16, 2024 09:31
@Hinton Hinton requested a review from merissaacosta December 16, 2024 09:31
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsef5ba72e-23ec-4452-9cd2-3517e1ca7f2e

No New Or Fixed Issues Found

@Hinton Hinton changed the title Fix strict typescript for Component Library stories Strict typescript for Component Library stories Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 33.45%. Comparing base (31be6a7) to head (0e9d10c).
Report is 147 commits behind head on main.

Files with missing lines Patch % Lines
...bs/components/src/form-field/form-field.stories.ts 0.00% 4 Missing ⚠️
...ibs/components/src/dialog/dialog/dialog.stories.ts 0.00% 3 Missing ⚠️
...omponents/src/form-field/bit-validators.stories.ts 0.00% 2 Missing ⚠️
libs/components/src/button/button.stories.ts 0.00% 1 Missing ⚠️
libs/components/src/search/search.stories.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12423      +/-   ##
==========================================
- Coverage   33.46%   33.45%   -0.01%     
==========================================
  Files        2908     2908              
  Lines       91057    91057              
  Branches    17336    17336              
==========================================
- Hits        30474    30467       -7     
- Misses      58177    58184       +7     
  Partials     2406     2406              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@merissaacosta merissaacosta requested review from vleague2 and removed request for merissaacosta December 16, 2024 19:41
@Hinton Hinton merged commit 9ca3d06 into main Jan 7, 2025
72 of 73 checks passed
@Hinton Hinton deleted the arch/cl-strict-ts-stories branch January 7, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants