Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16104] - add org-wide at-risk member dialog #12434

Open
wants to merge 2 commits into
base: risk-insights-final-demo
Choose a base branch
from

Conversation

jaasen-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16104

📔 Objective

This PR adds an org-wide list of at-risk members dialog. In includes a placeholder button to show the dialog, the content will eventually end up in a drawer.

📸 Screenshots

Screenshot 2024-12-16 at 3 51 59 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner December 16, 2024 23:52
Copy link
Contributor

github-actions bot commented Dec 17, 2024

Logo
Checkmarx One – Scan Summary & Detailsafcd7806-b21c-48cb-9908-b0ee975f3917

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /bitwarden_license/bit-web/src/app/tools/access-intelligence/org-at-risk-members-dialog.component.html: 17 Attack Vector

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 3.70370% with 26 lines in your changes missing coverage. Please review.

Project coverage is 33.34%. Comparing base (967a372) to head (3cc5f44).

Files with missing lines Patch % Lines
...ols/access-intelligence/risk-insights.component.ts 0.00% 10 Missing ⚠️
...telligence/org-at-risk-members-dialog.component.ts 0.00% 9 Missing ⚠️
...-insights/services/risk-insights-report.service.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           risk-insights-final-demo   #12434      +/-   ##
============================================================
- Coverage                     33.96%   33.34%   -0.62%     
============================================================
  Files                          2910     2911       +1     
  Lines                         92169    91066    -1103     
  Branches                      17775    17340     -435     
============================================================
- Hits                          31301    30365     -936     
+ Misses                        58450    58298     -152     
+ Partials                       2418     2403      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +8 to 13
<div *ngIf="isOrgAtRiskMembersFeatureEnabled">
<button bitButton buttonType="primary" type="button" (click)="showAtRiskMembers()">
View All At-Risk Members
</button>
</div>
<div
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For testing only, final form will display the results in a side drawer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant