Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16094] Remove lowercasing of vault page headers titles #12438

Merged

Conversation

djsmith85
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16094

📔 Objective

Nouns in different languages are capitalized. The .toLowerCase() used within the header overrides the translation which takes care of language-specific capitalization.

This was initially observed when using the German extension/web-vault

📸 Screenshots

Before

image
image

image
image

After

image
image

image
image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested a review from a team as a code owner December 17, 2024 11:19
Copy link
Contributor

github-actions bot commented Dec 17, 2024

Logo
Checkmarx One – Scan Summary & Details7db29af8-f0d6-4473-9df1-76f2ee285f63

No New Or Fixed Issues Found

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 33.49%. Comparing base (b7ec74d) to head (9fa720d).
Report is 71 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ponents/vault-v2/add-edit/add-edit-v2.component.ts 0.00% 5 Missing ⚠️
...s/vault-item-dialog/vault-item-dialog.component.ts 0.00% 5 Missing ⚠️
...p/components/vault-v2/view-v2/view-v2.component.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12438   +/-   ##
=======================================
  Coverage   33.49%   33.49%           
=======================================
  Files        2916     2916           
  Lines       91158    91158           
  Branches    17351    17351           
=======================================
  Hits        30533    30533           
  Misses      58218    58218           
  Partials     2407     2407           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djsmith85 djsmith85 linked an issue Dec 23, 2024 that may be closed by this pull request
1 task
Copy link
Member

@gbubemismith gbubemismith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼

@djsmith85 djsmith85 merged commit a07a7e9 into main Dec 30, 2024
43 checks passed
@djsmith85 djsmith85 deleted the vault/pm-16094/remove-lowercasing-of-vault-page-headers branch December 30, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper handling of translation token "viewItemHeader"
2 participants